[FEAT] 미션 API 마이그레이션 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- naver에서 microsoft azure image analysis api로 이전
naver -> Google cloud vision api로 이전
- joy, anger, sorrow, surprise 4개로 수정
## ☀️ 작업 사항 - 표정 인식 미션 객체 수정 - 표정 인식 ENUM 타입으로 파라미터 검사 ## ☀️ 관련 이슈 related: #80
hye-on
reviewed
Nov 28, 2023
| @Bean | ||
| GoogleCredentials googleCredentials() { | ||
| try (InputStream serviceAccount = new ClassPathResource(resourceName).getInputStream()) { | ||
| GoogleCredentials GoogleCredentials() { |
hye-on
reviewed
Nov 28, 2023
| GoogleCredentials googleCredentials() { | ||
| try (InputStream serviceAccount = new ClassPathResource(resourceName).getInputStream()) { | ||
| GoogleCredentials GoogleCredentials() { | ||
| try (InputStream serviceAccount = new ClassPathResource(credentials).getInputStream()) { |
There was a problem hiding this comment.
이름 수정한 이유가 궁금해요!
26번째 줄의 credentials하고 같은 이름으로 수정할려고 한 것일까요?
There was a problem hiding this comment.
네 resourcename이 애매한 변수명이라고 생각하여 수정했습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☀️ 작업 사항
☀️ 관련 이슈
related: #80
☀️ 참고 사항
ex) 강아지 사진 -> 강아지 품종이 결과로 나옴 -> 미션 실패