#25 Feature/edit user group #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05AM
approved these changes
Aug 20, 2023
Comment on lines
+24
to
+30
| protected ResponseEntity<BaseResponse<Status>> handleCustomException(BaseException exception) { | ||
| logger.debug("BaseResponse exception occurred: {}", exception.getMessage(), exception); | ||
|
|
||
| return new BaseResponse<>(exception.getStatus()); | ||
| Status status = exception.getStatus(); | ||
| ResponseEntity<BaseResponse<Status>> responseEntity = ResponseEntity.status(status.getHttpStatus()) | ||
| .body(new BaseResponse<>(status)); | ||
| return responseEntity; |
There was a problem hiding this comment.
혹시 왜 responseEntity로 바꿨는지 알 수 있을까?
나도 바꾸려고 생각했는데 이유를 아직 못 찾아서 실행하진 않았어서!
There was a problem hiding this comment.
우리가커스텀 에러를 내려줄때 data값으로 상태코드를 표시하는데
에러가 나도 상태코드가 200으로 나와서 일치시키려고 했어!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현
api