Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] AlarmCreateReq의 isVibrate를 타입을 Boolean으로 변경 #105

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

hye-on
Copy link
Contributor

@hye-on hye-on commented Mar 26, 2024

☀️ 작업 사항

AlarmCreateReq를 boolean -> Boolean으로 변경하였습니다.

☀️ 관련 이슈

☀️ 참고 사항

true 값이 제대로 안들어오고, 스웨거에 isVibrate가 아니라 vibrate로 표시되어서 찾아봤더니 아래와 같은 이유였습니다.
https://medium.com/@baejae/boolean%EC%97%90-is-%EB%B6%99%EC%9D%B4%EC%A7%80-%EB%A7%88%EC%84%B8%EC%9A%94-7b717246d942

image

@hye-on hye-on requested a review from 05AM March 26, 2024 05:30
@hye-on hye-on self-assigned this Mar 26, 2024
@hye-on hye-on added D-2 2일 전 까지 리뷰해주세요 FIX 수정 labels Mar 26, 2024
Copy link
Member

@05AM 05AM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 종종 헷갈리더라구요
확실히 라이브러리의 종속성을 여기서 체감하는 것 같습니다.

@hye-on hye-on merged commit 60088dc into main Mar 26, 2024
1 check passed
@hye-on hye-on deleted the fix/edit-AlarmCreateReq branch April 1, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-2 2일 전 까지 리뷰해주세요 FIX 수정
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants