Strings 2 #572
Merged
Strings 2 #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and replace strcmp with std::string operator== calls.
…r==. This commit also enables TinyXML STL support.
There exists bool CardInstance::hasSubtype(const string& _subtype) and the const char* version converts _subtype into string deeper in the call hierarchy anyway. So both methods did the same.
|
That one test fails also on my lokal machine sometimes. Regardless if these patches are applied or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace c string code with c++ versions (rebased, a second time). This rebase avoids the find a replace debacle and merges a few commits. No tests should fail now.