Defines/Typos #557
Merged
Defines/Typos #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines do not follow scope rules, but enums do. Enum classes even utilize strong type checking (but i am not sure about compiler support for c++11 on all target platforms).
This method is rarely used, however it returned 0 after adding stuff. It now returns the sum.
x and y is provided by PlayGuiObject::Pos.
Merge cleanup codings style commit as i accidentally used that branch as the base.
| for(int w = 0; w < int(abilities.size());w++) | ||
| { | ||
| currentAction = (ActionElement*)abilities[w]; | ||
| ActionElement *currentAction = (ActionElement*)abilities[w]; |
There was a problem hiding this comment.
We use ActionElement* currentAction or ActionElement * currentAction
|
Nice changes! I like when the code is getting cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits get rid of a few define groups and replaces them with enums (in class scopes).
There was also a typo in ActionLayer::receiveEventPlus(...) and two unused variables in Interruptible which are now gone.