Fix for flyout shift (elastic#142565)

WafaaNasr · Oct 11, 2022 · 1f55566 · 1f55566
1 parent 7da847e
commit 1f55566
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/...lugins/lens/public/editor_frame_service/editor_frame/config_panel/dimension_container.tsx b/...lugins/lens/public/editor_frame_service/editor_frame/config_panel/dimension_container.tsx
@@ -64,17 +64,20 @@ export function DimensionContainer({
   }, [handleClose]);
 
   useEffect(() => {
-    if (isOpen) {
-      document.body.classList.add('lnsBody--overflowHidden');
-    } else {
-      document.body.classList.remove('lnsBody--overflowHidden');
-    }
+    document.body.classList.toggle('lnsBody--overflowHidden', isOpen);
     return () => {
+      if (isOpen) {
+        setFocusTrapIsEnabled(false);
+      }
       document.body.classList.remove('lnsBody--overflowHidden');
     };
-  });
+  }, [isOpen]);
+
+  if (!isOpen) {
+    return null;
+  }
 
-  return isOpen ? (
+  return (
     <div ref={panelRef}>
       <EuiFocusTrap
         disabled={!focusTrapIsEnabled}
@@ -152,5 +155,5 @@ export function DimensionContainer({
         </div>
       </EuiFocusTrap>
     </div>
-  ) : null;
+  );
 }