This repository has been archived by the owner on Sep 27, 2023. It is now read-only.
Feature/use namespace #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…REST API Work in progress, last time autoloading was messed up so I need to fix this.
Rewrote it to include easier maintenance
The individual sniff will be removed, since we can run sniffer at once. Currently it's not working (config setup issues). JS part will have to be rewritten a bit.
Added runner that produces the report in the json, just need to see why the report looks like it's ran using the -vvv option, and it doesn't return classic sniffer results, but at least it's working now, kinda.
Missing env vars added
Made modifications to readme, added config class for easier extension, added dependency injection in the main plugin file instead of direct dependency in the methods when making add_action/filters, added activation check, updated composer.
Need to add loader, fix the stopping (or removing it), see how to implement the parallel option in the runner and create interfaces and spearate code according to classes better so that tests can be made.
Updated the composer and package.json and made the plugin more decoupled. Still need to figure out the enqueuing of the asset on the sniffer page only, because I'm not using asset awareness trait.
Fix js functions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.