Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule about setting INI during runtime in themes #219

Merged
merged 1 commit into from
May 20, 2019
Merged

Add rule about setting INI during runtime in themes #219

merged 1 commit into from
May 20, 2019

Conversation

dingo-d
Copy link
Member

@dingo-d dingo-d commented May 20, 2019

Add rule that forbids the setting of INI configuration in themes.

Related issue #209

@dingo-d dingo-d added this to the 0.2.0 milestone May 20, 2019
@dingo-d dingo-d requested a review from jrfnl May 20, 2019 07:22
@dingo-d dingo-d self-assigned this May 20, 2019
@dingo-d dingo-d mentioned this pull request May 20, 2019
Closed
jrfnl
jrfnl approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: the sniff contains two notices ..._Blacklisted which is already an error and Risky which is a warning. So in effect, this changes the Risky error code to an error.

@jrfnl jrfnl merged commit f490dc3 into develop May 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/add-php-ini-set-check branch May 20, 2019 08:33
@jrfnl jrfnl mentioned this pull request Jun 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees

@dingo-d dingo-d

Labels
enhancement
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dingo-d @jrfnl