Travis: test against high/low WPCS #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there are quite some sniffs which now extend WPCS sniffs, it would be prudent to test builds against a mix of PHPCS and WPCS versions. With the changes made in this PR, all sniffs will be tested against a combination of the highest PHPCS+WPCS versions as well as the lowest PHPCS+WPCS versions on most PHP versions. To also make sure that the sniffs work correctly with a different combi, the PHP 7.2 build will test with high PHPCS vs low WPCS and with low PHPCS vs high WPCS.
delete-merged-branch
bot
deleted the
feature/travis-test-against-various-wpcs-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As there are quite some sniffs which now extend WPCS sniffs, it would be prudent to test builds against a mix of PHPCS and WPCS versions.
With the changes made in this PR, all sniffs will be tested against a combination of the highest PHPCS+WPCS versions as well as the lowest PHPCS+WPCS versions on most PHP versions.
To also make sure that the sniffs work correctly with a different combi, the PHP 7.2 build will test with high PHPCS vs low WPCS and with low PHPCS vs high WPCS.