Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PrefixAllGlobals sniff to the ruleset. #130

Merged
merged 1 commit into from
May 31, 2018
Merged

Add PrefixAllGlobals sniff to the ruleset. #130

merged 1 commit into from
May 31, 2018

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 4, 2017 •
edited
Loading

⚠️ This PR should not be merged until WPCS has been merged back into the TRTCS as the sniff has only recently been added to WPCS.

Rebased after the merge of #145. Merging should now be fine.

Fixes #129

@jrfnl jrfnl force-pushed the feature/prefix-all-things branch from 660df5b to b0e2193 Compare May 27, 2018 12:01
@jrfnl
Copy link
Contributor Author

jrfnl commented May 27, 2018

Rebased & added link to WPCS wiki paragraph with info about the custom property (what it does & how to set it).

grappler
grappler approved these changes May 31, 2018
View reviewed changes
Copy link
Member

@grappler grappler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrfnl
Copy link
Contributor Author

jrfnl commented May 31, 2018

Also see: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/wiki/Customizable-sniff-properties#naming-conventions-prefix-everything-in-the-global-namespace about passing the prefixes.

@jrfnl jrfnl merged commit 027bf1e into feature/theme-review-sniffs May 31, 2018
@jrfnl jrfnl deleted the feature/prefix-all-things branch May 31, 2018 11:00
@jrfnl jrfnl mentioned this pull request Jun 2, 2018
Closed
@jrfnl jrfnl added this to the 0.1.0 milestone Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grappler grappler grappler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jrfnl @grappler