Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Theme Text domain #111

Closed

Conversation

grappler
Copy link
Member

fixes #35

With WordPress/WordPress-Coding-Standards#685 multiple text domains are supported and with WordPress/WordPress-Coding-Standards#807 we can easily pass the text domains via the cli.

phpcs -p . --standard=WordPress-Theme --runtime-set text_domain my-slug,default

Or via a custom ruleset.

<rule ref="WordPress.WP.I18n">
   <properties>
     <property name="text_domain" value="my-slug,default"/>
   </properties>
</rule>

We can then add the list of allowed framework text domains to the the Theme Check plugin.

@grappler grappler self-assigned this Jan 21, 2017
@grappler grappler requested a review from jrfnl January 21, 2017 19:03
@grappler grappler force-pushed the feature/issue-35-textdomain branch from d4aca1c to 89884a6 Compare January 21, 2017 19:04
Copy link
Contributor

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule is already includes in the ruleset on line 32. Suggest close.

@grappler
Copy link
Member Author

🤦‍♂️

@grappler grappler closed this Jan 21, 2017
@jrfnl jrfnl deleted the feature/issue-35-textdomain branch January 21, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants