Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New sniff] Check for <title> #25

Closed
2 tasks done
carolinan opened this issue Jul 12, 2016 · 3 comments
Closed
2 tasks done

[New sniff] Check for <title> #25

carolinan opened this issue Jul 12, 2016 · 3 comments
Assignees
@carolinan
Labels
issue: has PR

Comments

@carolinan
Copy link

carolinan commented Jul 12, 2016 •
edited by grappler
Loading

Rule:

ERROR : The theme must not use the <title> tag.

Ref: https://make.wordpress.org/themes/handbook/review/required/
"You should support up to 2 versions behind the current WordPress version."

The test and the sniff should include this exception: inline SVG code.

Theme check file covering this rule:

https://github.com/Otto42/theme-check/blob/master/checks/title.php

To do:

  • Create unit tests
  • Create new sniff
@emiluzelac
Copy link

Yep, we should let WordPress manage the document title and via add_theme_support( 'title-tag' ); instead.

https://make.wordpress.org/core/2014/10/29/title-tags-in-4-1/

@carolinan
Copy link
Author

carolinan commented Jul 12, 2016 •
edited
Loading

I believe there will be a separate sniff for the required add_theme_support.

@jrfnl jrfnl mentioned this issue Jul 16, 2016
Open
carolinan added a commit that referenced this issue Jul 20, 2016
@carolinan
Check that the title tag is not used
0e13800 
Partial solution for #25 . Changed from Error to Warning since it does
not deal with the false positive.
@grappler grappler mentioned this issue Jul 24, 2016
Merged
grappler pushed a commit that referenced this issue Oct 15, 2016
@carolinan @grappler
Check that the title tag is not used
ed11704 
Partial solution for #25 . Changed from Error to Warning since it does
not deal with the false positive.
grappler added a commit that referenced this issue Oct 27, 2016
@grappler
Add sniff to check that <title> tags are not used. (#41)
4f20d92 
Restricts the use of the <title> tag, unless it is within a <svg> tag.

https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features

Fixes (#25)
@grappler
Copy link
Member

grappler commented Dec 3, 2016

This has been merged

@grappler grappler closed this as completed Dec 3, 2016
@grappler grappler mentioned this issue Dec 10, 2016
Closed
72 tasks
@grappler grappler mentioned this issue Jan 15, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
issue: has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emiluzelac @grappler @carolinan