Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#40 Disable CMS-based creation of menusets by default #44

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

jakxnz
Copy link
Contributor

@jakxnz jakxnz commented Aug 14, 2020

#40

@jakxnz jakxnz changed the title 40 Disable CMS-based creation of menusets by default #40 Disable CMS-based creation of menusets by default Aug 14, 2020
@stecman
Copy link
Contributor

stecman commented Aug 14, 2020

Would it make sense to do this with permissions instead of a custom config option?

@jakxnz
Copy link
Contributor Author

jakxnz commented Aug 14, 2020

I did consider using provisioned permissions @stecman, but the only use case(s) I can think of is if your front-end
a) supports menu sets created by CMS authors, or
b) expects predefined (default) menu sets only.

So I figured a Config based switch was more in line with those cases.

(I'm assuming you meant permissions as in permission provider and custom config as in the Config API (not permissions as in canCreate() logic and custom config as in GridFieldConfig))

@jakxnz
Copy link
Contributor Author

jakxnz commented Mar 24, 2021

I did consider using provisioned permissions @stecman, but the only use case(s) I can think of is if your front-end
a) supports menu sets created by CMS authors, or
b) expects predefined (default) menu sets only.

So I figured a Config based switch was more in line with those cases.

(I'm assuming you meant permissions as in permission provider and custom config as in the Config API (not permissions as in canCreate() logic and custom config as in GridFieldConfig))

@stecman, Any word on this?

@wilr wilr merged commit 069267d into WPP-Public:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants