FIX: Don’t copy ID from target page on write #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camspiers
added a commit
that referenced
this pull request
Sep 23, 2015
FIX: Don’t copy ID from target page on write
|
Nice catch @kinglozzer thanks! |
|
@stecman can you manage the release for this fix? |
|
Released as 2.1.3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in
DataObject::write()for 3.2 highlighted this issue.DataObject::write()usesisInDB()which will check for an ID. If adding a new menu item, the ID is not set and it will be copied from the target page, resulting in SilverStripe trying to write to a row with the page’s ID instead of creating a new row.This didn’t happen in 3.1 because
DataObject::write()would access$this->record['ID']directly, bypassing__get().