-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TMEDIA-580 test only changed files on push and in actions #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackHowa
changed the title
TMEDIA-580 test on commit locally only changed files (pt 1)
BLOCKED TMEDIA-580 test on commit locally only changed files (pt 1)
Jan 4, 2022
…usion-news-theme-blocks into TMEDIA-580-test-commit-changed
…igger high code coverage restraints. Also it's breaking the code coverage on changed
JackHowa
changed the title
BLOCKED TMEDIA-580 test on commit locally only changed files (pt 1)
TMEDIA-580 test only changed files on push and in actions
Jan 4, 2022
JackHowa
changed the title
TMEDIA-580 test only changed files on push and in actions
IN PROGRESS PENDING DISCUSSION TMEDIA-580 test only changed files on push and in actions
Jan 4, 2022
…rotected branches
JackHowa
changed the title
IN PROGRESS PENDING DISCUSSION TMEDIA-580 test only changed files on push and in actions
TMEDIA-580 test only changed files on push and in actions
Jan 6, 2022
matthewroach
suggested changes
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small name changes to remove "news theme" references
Co-authored-by: Matthew Roach <[email protected]>
Co-authored-by: Matthew Roach <[email protected]>
Good call @matthewroach -- updated |
matthewroach
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test locally only changed files on push* to improve dev productivity
Jira Ticket
Acceptance Criteria
Test Steps
git checkout TMEDIA-580-test-commit-changed
rm -rf node_modules && npm i
for new jest versionconst ArticleByline = () => <Byline font="Primary" />;
->const ArticleByline = () => <p>by</p>;
git add blocks/byline-block/features/byline/default.jsx
git commit -m "only byline"
git push
. See the linting run (deferred to future ticket). See the only files changed are being tested. This should failgit reset --hard origin/TMEDIA-580-test-commit-changed
Effect Of Changes
Before
After
Dependencies or Side Effects
coverageThreshold
configurable on the cli jestjs/jest#8474Author Checklist
The author of the PR should fill out the following sections to ensure this PR is ready for review.
npm run lint
to check for errors. Often,npm run lint:fix
will fix those errors and warnings. -> nanpm run test:coverage
to see your progress.npm run test
, made sure all tests are passingplease explain why (so that we can fix it whenever it gets refactored). -> na
Reviewer Checklist
The reviewer of the PR should copy-paste this template into the review comments on review.