Add Findbugs #618
Add Findbugs #618
Conversation
Current coverage is 57.67% (diff: 66.66%)@@ master #618 diff @@
==========================================
Files 195 195
Lines 6089 6091 +2
Methods 0 0
Messages 0 0
Branches 554 554
==========================================
+ Hits 3512 3513 +1
- Misses 2413 2414 +1
Partials 164 164
|
| def slurped = new XmlSlurper().parse(xmlReport.destination) | ||
| def bugsFound = slurped.BugInstance.size() | ||
| if (bugsFound > 0) { | ||
| new XmlNodePrinter().printList(slurped.BugInstance.list()) |
There was a problem hiding this comment.
@JLLeitschuh I am doing something wrong here. Any idea how to make this work?
There was a problem hiding this comment.
@AustinShalit @JLLeitschuh what's the problem? If it's not printing, it's likely because, to my knowledge, XmlNodePrinter requires an output (try passing System.out as a constructor argument)
# Conflicts: # .travis.yml # appveyor.yml # build.gradle # core/src/main/java/edu/wpi/grip/core/OperationDescription.java
AustinShalit
force-pushed
the
findbugs
branch
2 times, most recently
from
22437d5 to
d3d5a9c
Compare
|
I am done for the night. This guide is very useful: http://findbugs.sourceforge.net/bugDescriptions.html Also, what do you think about getting this in for 2.0.0? |
|
Works on OS X 10.11.5 and Ubuntu 15.10 👍 |
|
Should leave comments on the |
| @@ -69,6 +71,7 @@ | |||
| } | |||
|
|
|||
| @Override | |||
| @SuppressFBWarnings("UW_UNCOND_WAIT") // Bug in FindBugs. There is a condition. | |||
There was a problem hiding this comment.
There's actually a field in the warning that you can fill out called "justification"
http://findbugs.sourceforge.net/api/edu/umd/cs/findbugs/annotations/SuppressFBWarnings.html#justification()
So you can do @SuppressFBWarnings("UW_UNCOND_WAIT", justification = "Bug in FindBugs. There is a condition.")
There was a problem hiding this comment.
Nice. I updated the suppressions to use that.
# Conflicts: # .travis.yml # appveyor.yml # core/src/test/java/edu/wpi/grip/core/sources/CameraSourceTest.java # core/src/test/java/edu/wpi/grip/core/util/service/AutoRestartingServiceTest.java
|
This good? |
|
Yup |
Closes #615
I still need to go through and fix failing tests.