Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated C++ doesn't compile #797

Closed
SamCarlberg opened this issue Jan 23, 2017 · 0 comments
Closed

Generated C++ doesn't compile #797

SamCarlberg opened this issue Jan 23, 2017 · 0 comments
Assignees
@SamCarlberg
Labels
HIGH PRIORITY location: codegen

Comments

@SamCarlberg
Copy link
Member

SamCarlberg commented Jan 23, 2017 •
edited
Loading

  • The .cpp still declares the setsourceN functions
  • VIsionPipeline include is wrong (should be #include "vision/VisionPipeline.h")
  • FindBlobs is missing a cv:: namespace qualifier
  • Includes the contrib module (and several others) even when it's not used, and may not compile on systems that don't or can't have it installed (e.g. FRC)
@SamCarlberg SamCarlberg self-assigned this Jan 23, 2017
SamCarlberg added a commit to SamCarlberg/GRIP that referenced this issue Jan 23, 2017
@SamCarlberg
Fix various issues with generated C++
0f4c27c 
Closes WPIRoboticsProjects#797
@SamCarlberg SamCarlberg mentioned this issue Jan 23, 2017
Merged
@nightpool nightpool mentioned this issue Jan 24, 2017
Closed
@333fred 333fred mentioned this issue Jan 27, 2017
Closed
SamCarlberg added a commit that referenced this issue Jan 30, 2017
@SamCarlberg
Fix various issues with generated C++ (#798)
8d3fa6c 
* Fix various issues with generated C++

Closes #797

* frc namespace, add override keyword

* Capital 'P' in 'Process'

* Fix integer division in filterContours

Closes #810

* Remove include for contrib module

* Clean up generated doc comments

* Capitalize C++ getter methods

All public C++ functions should be PascalCase now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamCarlberg SamCarlberg

Labels
HIGH PRIORITY location: codegen
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nightpool @SamCarlberg