Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LibraryFiltersComponent): add research project filtering functionality #2036

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Jan 9, 2025

Changes

  • This change set allows authors to specify ResearchProject (RP) tags ("NLP-TIPS", "ARISE", etc) to library units. This is represented in the project JSON in metadata.researchProjects array. This will allow teachers and grant reviewers to quickly search for units that were created for certain research projects.
  • Add select menu that appears only when there are library units with RP tags
  • Update the filtered units according to the users' selections of the new RP tags

Setup

  • To add RP tag to a unit, open the unit's JSON editing view in the AT and add the following field to the metadata block:
        "researchProjects": [
            "ARISE",
            "NLP-TIPS"
        ],

Test

Closes #2035

@hirokiterashima hirokiterashima self-assigned this Jan 9, 2025
@hirokiterashima hirokiterashima requested a review from breity January 9, 2025 19:44
@hirokiterashima hirokiterashima marked this pull request as ready for review January 9, 2025 19:44
@hirokiterashima hirokiterashima changed the title refactor(LibraryFiltersComponent): add research project filtering functionality feat(LibraryFiltersComponent): add research project filtering functionality Jan 9, 2025
@breity breity self-requested a review January 10, 2025 20:04
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I made one code comment.

@hirokiterashima hirokiterashima merged commit 761b59c into develop Jan 13, 2025
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the research-project-library-filter branch January 13, 2025 18:59
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.165.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Unit Library): Add Research Project unit filter
2 participants