Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Multilingual Unit): Copy single component generates new translations #1852

Conversation

hirokiterashima
Copy link
Member

Changes

  • Copying a single component generates new translations ids and copies over translations for the new component
  • Note: to keep the scope small, I did not implement copying components via other methods.

Test

  • In the node authoring view, click on the "Copy component" button for a component (not the checkbox -> copy method). This should:
    • copy the component
    • generate new translation ids for the new component (look at project.json)
    • copy the translations that were in the original component, but with new the new translation ids (look at translations.[language].json)
  • Deleting components deletes translations from the translations.[language].json files as before. I extracted common code to a new EditTranslationsService class.

@hirokiterashima hirokiterashima self-assigned this Jul 5, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review July 5, 2024 05:40
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 9b94617 into issue-1513-multiple-languages-per-unit Jul 8, 2024
@hirokiterashima hirokiterashima deleted the multilingual-copy-single-component branch July 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants