Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Translation): Make graph authoring inputs translatable #1699

Merged
merged 3 commits into from
Mar 21, 2024
Merged

feat(Translation): Make graph authoring inputs translatable #1699

merged 3 commits into from
Mar 21, 2024

Conversation

breity
Copy link
Member

@breity breity commented Mar 18, 2024

Changes

  • Convert Graph item inputs to translatable inputs.
  • Clean up and simplify styles.

Test

Author a Graph item and make sure the following fields are translatable

  • Graph Title
  • X-Axis Title
  • X-Axis Units
  • Y-Axis Title
  • Y-Axis Units
  • Y-Axis Title (when multiple y-axes are enabled)
  • Y-Axis Units (when multiple y-axes are enabled)
  • Series Name

@breity breity requested a review from geoffreykwan March 18, 2024 20:17
@breity breity self-assigned this Mar 18, 2024
geoffreykwan
geoffreykwan requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in the main graph authoring looks good. The fields in the advanced graph authoring popup still need to be converted such as

  • Subtitle
  • Custom Legend
  • X Axis Plot Line (Text)
  • Y Axis Plot Line (Text)
  • Default Feedback on Submit

@breity
Copy link
Member Author

breity commented Mar 20, 2024

@geoffreykwan, thanks. I converted the advanced fields to translatable inputs.

The default feedback on submit field is a separate component, so I didn't include it here. I think we should convert that in a separate PR.

@breity breity requested a review from geoffreykwan March 20, 2024 16:48
geoffreykwan
geoffreykwan approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@breity breity merged commit b3bcf2b into issue-1513-multiple-languages-per-unit Mar 21, 2024
@breity breity deleted the convert-graph-inputs-to-translatable branch March 21, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@breity breity

Labels
None yet
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@breity @geoffreykwan