Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Translation): Convert summary item inputs to translatable #1688

Merged
merged 1 commit into from
Mar 19, 2024
Merged

feat(Translation): Convert summary item inputs to translatable #1688

merged 1 commit into from
Mar 19, 2024

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Mar 12, 2024 •
edited
Loading

Changes

  • Convert Summary item inputs to translatable inputs

Test

  • Author a Summary item and make sure the custom label colors are translatable

@geoffreykwan geoffreykwan self-assigned this Mar 12, 2024
@geoffreykwan geoffreykwan marked this pull request as ready for review March 12, 2024 22:22
@geoffreykwan geoffreykwan requested review from hirokiterashima and breity and removed request for hirokiterashima March 12, 2024 22:25
breity
breity approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@geoffreykwan geoffreykwan merged commit fcd443c into issue-1513-multiple-languages-per-unit Mar 19, 2024
@geoffreykwan geoffreykwan deleted the convert-summary-item-inputs-to-translatable branch March 19, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffreykwan @breity