Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Translation): Make embedded component authoring inputs translatable #1685

Conversation

breity
Copy link
Member

@breity breity commented Mar 11, 2024

Changes

  • Convert authoring input for Model Parameters field in advanced authoring for embedded components to translatable input.

Note: The Model File Name field should also be translatable, but it is tied to a file chooser, which doesn't yet work with translatable inputs. This will be made translatable in a separate PR.

Test

  • Author an embedded component and make sure the "Model Parameters" field in the advanced authoring is translatable.

@breity breity requested a review from hirokiterashima March 11, 2024 23:22
@breity breity self-assigned this Mar 11, 2024
@breity breity merged commit b40ab99 into issue-1513-multiple-languages-per-unit Mar 12, 2024
@breity breity deleted the convert-embedded-inputs-to-translatable branch March 12, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants