Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TranslatableInput): Move default language text to hint #1590

Merged

Conversation

breity
Copy link
Member

@breity breity commented Jan 25, 2024

Changes

Move the default language text display to a hint for the form field.

Test

Make sure default language text appears directly below input (in a mat-hint element) field when translating to a supported language.

@breity breity self-assigned this Jan 25, 2024
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breity breity merged commit dd2d26e into issue-1513-multiple-languages-per-unit Jan 25, 2024
@breity breity deleted the move-default-language-to-hint branch January 25, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants