Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Multiple Languages): Show current language in TranslatableInput's label #1588

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat(Multiple Languages): Show current language in TranslatableInput's label #1588

merged 2 commits into from
Jan 25, 2024

Conversation

hirokiterashima
Copy link
Member

Changes

  • Display language word directly in the TranslatableInput label “[label] (Language)”, e.g. "Prompt (Japanese)", "Choice Text (Spanish)". This helps the translator know to type the translation for the currently-selected language.

Test in AT with supported languages

  • Switch between languages
    • When you choose a supported language, the TranslatableInput shows the selected language in the label.
    • When you choose the default language, TranslatableInput does not show the language.
image

@hirokiterashima hirokiterashima self-assigned this Jan 25, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review January 25, 2024 00:29
breity
breity approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

Ready to merge after removing the i18n attribute I mentioned.

src/assets/wise5/authoringTool/components/translatable-input/translatable-input.component.html Outdated Show resolved Hide resolved
@hirokiterashima hirokiterashima merged commit 89b5cd9 into issue-1513-multiple-languages-per-unit Jan 25, 2024
@hirokiterashima hirokiterashima deleted the multiple-languages-show-current-language-in-input branch January 25, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
1 point
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @breity