-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Edit Project Info): Multiple languages setting #1546
feat(Edit Project Info): Multiple languages setting #1546
Conversation
Allow users to select default language and supported languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some things I noticed.
-
Language settings do not get saved if the project does not have a metadata.locale field. All old and new projects do not have a metadata.locale field.
-
If the default language is not added to "additional languages", the default language will not show up in the student upper right language select so they won't be able to switch back to the default language.
-
Should the languages in the drop downs be ordered alphabetically?
-
Do we need to specify "Dutch (Netherlands)" or is "Dutch" by itself ok?
-
The "additional languages" select adding/deleting feels a little inconsistent. When you add a language, it closes the drop down. When you have the drop down open and delete a language by clicking it in the drop down, it keeps the drop down open.
Here are potential other configurations to consider.
Here is an example of the drop down staying open when adding and deleting. (use the first demo and open the drop down and delete and then add "Karyn Wright")
Here is an example of options being removed from the drop down and only being able to delete using the x button. (use the second demo and add and then delete "Karyn Wright")
This used to work when we used to also store default language in supported array. Now, supported array does not support default locale.
when there is 1 supported language
…anguages-edit-languages-options-in-at
@geoffreykwan good catch. I think I've resolved all the issues you found. PTAL. Remember this branch still uses the old project.json format using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Notes
Changes
Test (in Unit Authoring > Info view)
Test (in unit preview and student VLE views)