Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Timestamp): Save annotations, events, student work with milliseconds #278

Conversation

geoffreykwan
Copy link
Member

Changes

  • Save annotations, events, and student work with milliseconds

Run these mysql database queries to update the column types

alter table annotations modify column clientSaveTime datetime(3) not null;
alter table annotations modify column serverSaveTime datetime(3) not null;

alter table events modify column clientSaveTime datetime(3) not null;
alter table events modify column serverSaveTime datetime(3) not null;

alter table studentWork modify column clientSaveTime datetime(3) not null;
alter table studentWork modify column serverSaveTime datetime(3) not null;

Test

Closes #277

Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@geoffreykwan geoffreykwan merged commit 74d358e into develop Aug 11, 2024
3 checks passed
@geoffreykwan geoffreykwan deleted the issue-277-save-annotations-events-student-work-timestamps-with-milliseconds branch August 11, 2024 19:30
@geoffreykwan
Copy link
Member Author

🎉 This issue has been resolved in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix(Timestamp): Save annotations, events, student work with milliseconds
3 participants