Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tag): Implement delete tag endpoint #266

Merged
merged 1 commit into from
Apr 5, 2024
Merged

feat(Tag): Implement delete tag endpoint #266

merged 1 commit into from
Apr 5, 2024
+34 −0

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Apr 5, 2024 •
edited
Loading

Changes

  • Implemented endpoint to delete tag

Test

@geoffreykwan geoffreykwan self-assigned this Apr 5, 2024
@geoffreykwan geoffreykwan mentioned this pull request Apr 5, 2024
Merged
@geoffreykwan geoffreykwan marked this pull request as ready for review April 5, 2024 19:26
@hirokiterashima hirokiterashima self-requested a review April 5, 2024 20:10
hirokiterashima
hirokiterashima approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Future considerations:

  1. I noticed that we're testing for AccessDenied in the Service level. Should we be doing this sooner, in the Controllers?
  2. UserTag should be renamed to ProjectTag?

@geoffreykwan geoffreykwan merged commit 485eadc into issue-259-implement-unit-tagging Apr 5, 2024
0 of 2 checks passed
@geoffreykwan geoffreykwan deleted the delete-tag-endpoint branch April 5, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffreykwan @hirokiterashima