feat(Teacher): Implement unit tagging

[geoffreykwan]

Changes

• Added the ability to create, edit, and delete tags
• Added the ability to apply and remove tags from units

Run this mysql database query to add the color column to the user_tags table

alter table user_tags add column color varchar(25) after text;

Test

• Test with feat(Teacher): Implement unit tagging WISE-Client#1813

Closes #259

[hirokiterashima]

The functionality mostly works.

It looks like the number of tags in the message when you try to delete a tag is off. In the screenshot below, you can see that I have "tag3" on a unit, but the cofirmation message says "0" I think it may not be counting the tags that are on the units (as opposed to run units).

I also added some code cleaning suggestions inline.

Lastly, maybe we should also apply the code cleaning conventions for at least the new standalone components, like alphabetizing (imports -> selector -> standalone...), rename "styleUrls" -> "styleUrl", self-closing tags, and such?

[hirokiterashima]

Oops. The comment above was intended for the WISE-Client PR. I have yet to review this PR.

[hirokiterashima]

Does this PR need to make changes to wise_db_init.sql?

Also, see inline comments. I wonder if the functions in [UserTag,TagProject]Controller should return the object directly instead of wrapping it in ResponseEntity. I think Spring automatically returns 200 (unless there's an error), and 404 (if the function exists due to an exception)?

[geoffreykwan]

I removed the ResponseEntity from TagProjectController.java. I kept it in the UserTagController.java because the client side looks for the error field to contain 'tagAlreadyExists' to show an error message. I've also updated wise_db_init.sql to include the color column in the user_tags table.

[hirokiterashima]

For error handling- can we do something similar to how we handle invalid name when creating user accounts?
We throw an InvalidNameException in StudentAPIController.createStudentAccount(), which is handled in register-student-form.component.createAccount(). It looks like we use @ControllerAdvice in CustomGlobalExceptionHandler.java to handle the InvalidNameException and return a ResponseEntity there.

This will separate out the concerns and make the functions in UserTagController easier to read. They won't need to wrap the return value in ResponseEntityGenerator.createSuccess/createError each time.

[geoffreykwan]

Ok, we now throw a TagAlreadyExistsException.

[hirokiterashima]

See my inline comment in UserTagController. Do we need to use ResponseEntityGenerator?

[geoffreykwan]

Ok, I've removed the usage of ResponseEntityGenerator.

[hirokiterashima]

LGTM

[breity]

Looks good. 👍

[geoffreykwan]

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀