Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include section on cleartext req/resp headers #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lusayaa
Copy link
Contributor

@lusayaa lusayaa commented Jan 7, 2025

To match KV IETF spec

FLEDGE_Key_Value_Server_API.md Outdated Show resolved Hide resolved
FLEDGE_Key_Value_Server_API.md Outdated Show resolved Hide resolved
FLEDGE_Key_Value_Server_API.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@JensenPaul JensenPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peiwenhu should also review

@@ -61,9 +61,20 @@ For more information on the design, please refer to [the trust model explainer](

![V2 API diagram](assets/fledge_kv_server_v2_api.png)

HTTPS is used to transport data. The method is `POST`.
The request contains an outer HTTP layer with an inner HTTP body that uses a repurposed [Oblivious HTTP](https://datatracker.ietf.org/doc/draft-ietf-ohai-ohttp/) encapsulation mechanism.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The request contains an outer HTTP layer with an inner HTTP body that uses a repurposed [Oblivious HTTP](https://datatracker.ietf.org/doc/draft-ietf-ohai-ohttp/) encapsulation mechanism.
The request contains an outer HTTP layer with an inner [Oblivious HTTP](https://datatracker.ietf.org/doc/draft-ietf-ohai-ohttp/) layer.

### Outer HTTP layer
For the outer HTTP layer:
* HTTPS is used to transport data.
* The method is `POST`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The method is `POST`.
* The HTTP method is `POST`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants