Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Fix wrong IG size for updates #1224

Merged
merged 2 commits into from
Jul 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ This is detectable because it can change the set of fields that are read from th

* |group|["{{GenerateBidInterestGroup/updateURL}}"] [=map/exists=].
1. Set |interestGroup|'s [=interest group/additional bid key=] to |decodedKey|.
1. If |interestGroup|'s [=interest group/estimated size=] > 1048576, then [=exception/throw=] a
1. If |interestGroup|'s [=interest group/estimated size=] > 1048576 bytes, then [=exception/throw=] a
{{TypeError}}.
1. Let |p| be [=a new promise=].
1. Let |queue| be the result of [=starting a new parallel queue=].
Expand Down Expand Up @@ -4427,7 +4427,7 @@ navigating to another page. Some implementations, such as Chromium, have chosen
following conditions hold:
* |ig|'s [=interest group/ads=] is not null, and |ig|'s [=interest group/additional bid key=]
is not null;
* |ig|'s [=interest group/estimated size=] is greater than 50 KB.
* |ig|'s [=interest group/estimated size=] is greater than 1048576 bytes.
1. Set |ig|'s [=interest group/next update after=] to the [=current wall time=] plus 24 hours.
1. Set |ig|'s [=interest group/last updated=] to the [=current wall time=].
1. [=list/Replace=] the [=interest group=] that has |ig|'s [=interest group/owner=] and
Expand Down
Loading