Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exporting duplicate Lock-related definitions from monkeypatches. #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented Dec 17, 2024

jyasskin added a commit to jyasskin/design-principles that referenced this pull request Dec 17, 2024
This can be reverted once
WICG/shared-storage#212 is merged and crawled.
martinthomson added a commit to w3ctag/design-principles that referenced this pull request Dec 17, 2024
* Improve the run-to-completion principle.

* "While an event loop is running" wasn't the right period to limit
  changes.
* We have a list of exceptions to this principle.

* Warn against letting an attribute change in the middle of a statement.

* Apply Martin's suggestions.

Co-authored-by: Martin Thomson <[email protected]>

* Remove a redundant sentence of emphasis on not changing attributes in the middle of a statement.

* Be more general than `while true`.

Co-authored-by: Martin Thomson <[email protected]>

* Move a positive statement to the top of the principle.

* Remove irrelevant and incorrect claims.

* It doesn't matter whether JS is a wrapper around code in another language.
* JS doesn't always get to complete: users can kill it.

* Apply changes resulting from Jan-Ivar's code review

Co-authored-by: Jan-Ivar Bruaroey <[email protected]>

* Identify which LockManager.

This can be reverted once
WICG/shared-storage#212 is merged and crawled.

---------

Co-authored-by: Martin Thomson <[email protected]>
Co-authored-by: Jan-Ivar Bruaroey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant