Scroll to the start node of the first text directive instead of its common ancestor #259

jnjaeschke · 2024-07-09T16:50:59Z

If a text directive should be scrolled to, it should be visible in the center of the view. However, scrolling the common ancestor of a range into the center of the view is not necessarily scrolling the range into view.

Example:

<html>
  <style>
    .space {
      margin-top: 200vh;
    }
  </style>
  <body>
    <p class="space">Test</p>
    <p class="space">Test2</p>
  </body>
</html>

Text Directive: :~:text=Test,Test2

An implementation that follows the spec would scroll in between the two <p>, so that neither Test nor Test2 would be visible. This is confusing for users. Therefore, my proposal is to change the spec so that the start container of the range is visible at the center of the view instead of the common ancestor.

Chrome already follows this proposal and scrolls Test into the center of the view. Safari and Gecko (as of now) follow the spec. I'm planning to change the implementation in Gecko to align with Chrome.

/cc @zcorpan

The text was updated successfully, but these errors were encountered:

bokand · 2024-07-09T20:53:54Z

Yeah, I agree that makes more sense. The intent here was that the first common ancestor is used to set the :target pseudo class since we can only set it on one element (I think?). But scrolling to it seems like a bug - we could separate the element used for :target and scroll the start container as you suggest.

annevk · 2024-07-11T09:06:41Z

cc @megangardner

…ad of its common ancestor. Spec issue: WICG/scroll-to-text-fragment#259 Differential Revision: https://phabricator.services.mozilla.com/D216147 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1906895 gecko-commit: 91c93776446c64bb2438b0fa69d0b9f198bb00a9 gecko-reviewers: emilio

…nto view instead of its common ancestor. r=emilio Spec issue: WICG/scroll-to-text-fragment#259 Differential Revision: https://phabricator.services.mozilla.com/D216147

…ad of its common ancestor. Spec issue: WICG/scroll-to-text-fragment#259 Differential Revision: https://phabricator.services.mozilla.com/D216147 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1906895 gecko-commit: 91c93776446c64bb2438b0fa69d0b9f198bb00a9 gecko-reviewers: emilio

…nto view instead of its common ancestor. r=emilio Spec issue: WICG/scroll-to-text-fragment#259 Differential Revision: https://phabricator.services.mozilla.com/D216147

…ad of its common ancestor. Spec issue: WICG/scroll-to-text-fragment#259 Differential Revision: https://phabricator.services.mozilla.com/D216147 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1906895 gecko-commit: 91c93776446c64bb2438b0fa69d0b9f198bb00a9 gecko-reviewers: emilio

moz-wptsync-bot mentioned this issue Jul 15, 2024

[Gecko Bug 1906895] Text Fragments: Scroll the start container of a range into view instead of its common ancestor. web-platform-tests/wpt#47125

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scroll to the start node of the first text directive instead of its common ancestor #259

Scroll to the start node of the first text directive instead of its common ancestor #259

jnjaeschke commented Jul 9, 2024

bokand commented Jul 9, 2024

annevk commented Jul 11, 2024

Scroll to the start node of the first text directive instead of its common ancestor #259

Scroll to the start node of the first text directive instead of its common ancestor #259

Comments

jnjaeschke commented Jul 9, 2024

bokand commented Jul 9, 2024

annevk commented Jul 11, 2024