Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the activation behavior of a <portal> element. #223

Merged
merged 6 commits into from
Jul 7, 2020
Merged

Define the activation behavior of a <portal> element. #223

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e77c74
Define the activation behavior of a <portal> element.
jeremyroman Jul 4, 2020
957786d
expand the activate(options) steps and tweak
jeremyroman Jul 6, 2020
1ab7476
may -> might in non-normative note
jeremyroman Jul 7, 2020
8d62cf9
abort these steps -> return
jeremyroman Jul 7, 2020
f401fc9
drop this from non-WebIDL algorithm
jeremyroman Jul 7, 2020
533c846
explainer updates
jeremyroman Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 36 additions & 10 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ spec:url; type:dfn; text:scheme

<section algorithm="portal-browsing-context-activate">
To <dfn>activate a portal browsing context</dfn> |successorBrowsingContext| in
place of |predecessorBrowsingContext| with [=origin=] |sourceOrigin|, data
|serializeWithTransferResult|, and promise |promise|, run the following steps [=in parallel=]:
place of |predecessorBrowsingContext| with [=origin=] |sourceOrigin|, optional data
|serializeWithTransferResult|, and optional promise |promise|, run the following steps [=in parallel=]:

1. [=Assert=]: The [=portal state=] of |predecessorBrowsingContext| is "`none`".

Expand Down Expand Up @@ -167,8 +167,8 @@ spec:url; type:dfn; text:scheme

1. Let |dataClone| be null.

1. If |successorBrowsingContext|'s [=active document=]'s [=Document/origin=] is
[=same origin=] with |sourceOrigin|, then:
1. If |serializeWithTransferResult| is given and |successorBrowsingContext|'s [=active document=]'s
[=Document/origin=] is [=same origin=] with |sourceOrigin|, then:

1. Let |deserializeRecord| be
[$StructuredDeserializeWithTransfer$](|serializeWithTransferResult|, |targetRealm|),
Expand All @@ -186,7 +186,7 @@ spec:url; type:dfn; text:scheme

1. Set |event|'s [=PortalActivateEvent/successor window=] to |successorWindow|.

1. Set |event|'s [=PortalActivateEvent/activation promise=] to |promise|.
1. Set |event|'s [=PortalActivateEvent/activation promise=] to |promise|, if it is given, and null otherwise.

1. [=Dispatch=] |event| to |successorWindow|.

Expand Down Expand Up @@ -217,7 +217,7 @@ spec:url; type:dfn; text:scheme

1. Otherwise:

1. [=Queue a global task=] on the [=portal task source=] given
1. If |promise| is given, [=queue a global task=] on the [=portal task source=] given
|predecessorBrowsingContext|'s [=browsing context/active window=] to resolve
|promise| with undefined.

Expand Down Expand Up @@ -630,6 +630,33 @@ spec:url; type:dfn; text:scheme
portals-cross-origin-load.sub.html
</wpt>

<section algorithm="htmlportalelement-activation-behavior">
A <{portal}> element's [=activation behavior=] is to run the following steps:

1. Let |portalBrowsingContext| be the [=guest browsing context=] of [=this=].
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not in a Web IDL method, so [=this=] doesn't exist. Probably it's best to say "A portal element el's activation behavior is to run the following steps:" and then use el throughout.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.


1. If |portalBrowsingContext| is null, abort these steps.
jeremyroman marked this conversation as resolved.
Show resolved Hide resolved

1. Let |predecessorBrowsingContext| be the [=document browsing context|browsing context=] of
[=this=]'s [=node document=].

1. If |predecessorBrowsingContext| is null, abort these steps.
jeremyroman marked this conversation as resolved.
Show resolved Hide resolved

1. If the [=portal state=] of |predecessorBrowsingContext| is not "`none`", abort these steps.
jeremyroman marked this conversation as resolved.
Show resolved Hide resolved

1. Let |sourceOrigin| be [=this=]'s [=relevant settings object=]'s
[=environment settings object/origin=].

1. Run the steps to [=activate a portal browsing context|activate=] |portalBrowsingContext|
in place of |predecessorBrowsingContext| with |sourceOrigin|.

<div class="note">
This is substantially similar to the steps in {{activate(options)}}, with default options.
User agents may wish to display suitable console messages under the same conditions that would
jeremyroman marked this conversation as resolved.
Show resolved Hide resolved
result in promise rejection in those steps.
</div>
</section>

The following events are dispatched on {{HTMLPortalElement}} objects:

<table class="data" dfn-for="HTMLPortalElement">
Expand Down Expand Up @@ -816,7 +843,7 @@ spec:url; type:dfn; text:scheme

A {{PortalActivateEvent}} has an associated <dfn for="PortalActivateEvent">predecessor browsing context</dfn>,
which is a [=top-level browsing context=] or null, a <dfn for="PortalActivateEvent">successor window</dfn>, which is
a {{Window}}, an <dfn for="PortalActivateEvent">activation promise</dfn>, which is a [=promise=], and a
a {{Window}}, an <dfn for="PortalActivateEvent">activation promise</dfn>, which is a [=promise=] or null, and a
<dfn for="PortalActivateEvent">adopted predecessor element</dfn>, which is a <{portal}> element or null.

<section algorithm="portalactivateevent-event-constructing-steps">
Expand Down Expand Up @@ -847,9 +874,8 @@ spec:url; type:dfn; text:scheme

1. Set [=this=]'s [=PortalActivateEvent/adopted predecessor element=] to |adoptedPredecessorElement|.

1. [=Queue a global task=] on the [=portal task source=] given |predecessorBrowsingContext|'s
[=browsing context/active window=] to resolve [=this=]'s [=activation promise=] with
undefined.
1. If [=this=]'s [=activation promise=] is not null, [=queue a global task=] on the [=portal task source=]
given |predecessorBrowsingContext|'s [=browsing context/active window=] to resolve it with undefined.

Note: Queuing this immediately makes it possible to send messages to the adopted
portal during dispatch of the {{Window/portalactivate!!event}} event without
Expand Down