Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict navigate firing when another window initiates the navigation #80

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

domenic
Copy link
Collaborator

@domenic domenic commented Mar 18, 2021

Closes #75, although this leaves open potential issues with history traversal from other documents which we'll track in #78.

@natechapin to review. /cc @csreis as a FYI.


Preview | Diff

Closes #75, although this leaves open potential issues with history traversal from other documents which we'll track in #78.
@domenic domenic requested a review from natechapin March 18, 2021 22:50
README.md Outdated
@@ -1115,9 +1118,10 @@ The web platform has many ways of initiating a navigation. For the purposes of t
- Bookmarks
- `<a>` and `<area>` elements (both directly by users, and programmatically via `element.click()` etc.)
- `<form>` elements (both directly by users, and programmatically via `element.submit()` etc.)
- As as special case of the above, the `target="nameOfSomeWindow"` attribute on `<a>`, `<area>`, and `<form>` will navigate a window whose `window.name` is `nameOfSomeWindow`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"as" -> "a"

@domenic domenic merged commit 590f061 into main Mar 19, 2021
@domenic domenic deleted the no-other-window-interception branch March 19, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Probably don't allow interception of navigations from other documents
2 participants