-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should event.navigationType for reloads be "reload" or "replace"? #117
Labels
Comments
Since the |
domenic
added a commit
that referenced
this issue
May 27, 2021
domenic
added a commit
that referenced
this issue
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In working on #112 this came up. Currently it's specced as "replace", under the mental model that a reload is a same-URL replace.
Pros for treating reloads as "replace":
appHistory.navigate(appHistory.current.url, { replace: true })
andappHistory.reload()
/location.reload()
is not very important and developers probably want to treat them similarly.Potential reasons to separate reloads into a new "reload" type:
navigate
handlers actually want to handle reloads specially, e.g. clearing UI state or something to give the user a "fresh" experience.The text was updated successfully, but these errors were encountered: