Change the remove operation to be part of a directory handle. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnall
approved these changes
May 17, 2019
| @@ -291,7 +280,7 @@ interface FileSystemDirectoryHandle : FileSystemHandle { | |||
|
|
|||
| Promise<sequence<USVString>?> resolve(FileSystemHandle handle); | |||
|
|
|||
| Promise<void> removeRecursively(); | |||
| Promise<void> removeEntry(USVString name, optional FileSystemRemoveOptions options); | |||
There was a problem hiding this comment.
While I personally like remove, the web platform seems to have settled on delete for this operation.
So, WDYT of delete, or deleteEntry?
Also fine to leave the name as-is and let the TAG decide when we submit a review.
There was a problem hiding this comment.
I think I'll leave as is for now. Which web platform APIs were you referring to btw? I guess CacheStorage indeed uses delete, but for example DOM has removeChild and removeAttribute
Before each handle had a remove method that would remove the entry represented by the handle. This changes it to instead have a removeEntry method on a directory handle that will remove a child of that directory. This means it is no longer possible to delete an individual file or directory without having a handle to its parent, but otherwise feels like a slightly nicer API shape to me.
mkruisselbrink
force-pushed
the
change-remove-method
branch
from
1a2c82b to
bcd36d8
Compare
|
I was thinking primarily of WICG/cookie-store#46. I agree we shouldn't block the API improvements in this PR on the name, though. I'll open an issue to track the name and let folks chime in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before each handle had a remove method that would remove the entry
represented by the handle. This changes it to instead have a removeEntry
method on a directory handle that will remove a child of that directory.
This means it is no longer possible to delete an individual file or
directory without having a handle to its parent, but otherwise feels
like a slightly nicer API shape to me.
This fixes#54