-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplication with whatwg/fs #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing here to integrate with the whatwg fs spec seem to be the bits that deal with permissions, i.e. setting the query access and request access algorithms for entries? Are you planning to do that in a follow-up, or was that supposed to be in here as well?
index.bs
Outdated
@@ -25,6 +25,12 @@ urlPrefix: https://tc39.github.io/ecma262/; spec: ECMA-262 | |||
type: dfn; text: realm; url: realm | |||
urlPrefix: https://storage.spec.whatwg.org/; spec: storage | |||
type: dfn; text: storage; url: site-storage | |||
urlPrefix: https://fs.spec.whatwg.org/; spec: fs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should not be needed, but you might need to add export
tags to these definitions in the fs spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just merged whatwg/fs#8 (and whatwg/fs#75) which should have exported all the terms we need
index.bs
Outdated
@@ -63,43 +69,27 @@ files and directories they've been given access to, allowing the web apps to | |||
later regain access to the same content without requiring the user to select the | |||
same file again. | |||
|
|||
This API extends the API in [[FS]], which specifies an [=origin private file system=] | |||
which websites can get access to without having to first prompt the user for access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this whole description of what the other spec defines still makes sense in this spec? I'd focus more on what this spec adds to it, rather than what is already in the other fs spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I've pared this down to only mention what that spec is in relation to this one.
5e2ad77
to
d51bde1
Compare
I'll do this in a follow-up |
These links will soon be invalid, since we're about to remove all content from WICG/file-system-access that's duplicated with whatwg/fs Also updates the README to mention both specs See WICG/file-system-access#392 Change-Id: I90274697a69e1ca45c4626dca5cb7cad0a0c14dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4049000 Commit-Queue: Austin Sullivan <[email protected]> Reviewed-by: Daseul Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#1075237}
Fixes #342, fixes #370
Preview | Diff