Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove options parameter from constructor #367

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Remove options parameter from constructor #367

merged 1 commit into from
Apr 11, 2022

Conversation

fivedots
Copy link
Collaborator

@fivedots fivedots commented Apr 5, 2022

In order to prevent compatibility issues with WebKit, the options
parameter should be removed from create[Sync]AccessHandle().

For more context see whatwg/fs#19.

@fivedots
Remove options parameter from constructor
af5af7c 
In order to prevent caused compatibility issues with WebKit, the options
parameter should be removed from create[Sync]AccessHandle(). For more
context see whatwg/fs#19.
@fivedots fivedots requested a review from a-sully April 5, 2022 17:11
tomayac
tomayac approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I will update the developer-facing docs accordingly.

a-sully
a-sully approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@a-sully a-sully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fivedots fivedots merged commit 0f1b519 into main Apr 11, 2022
@fivedots fivedots deleted the undo-uptions-param branch April 11, 2022 17:28
github-actions bot added a commit that referenced this pull request Apr 11, 2022
@fivedots @github-actions
chore(rebuild): Merge pull request #367 from WICG/undo-uptions-param
0b71e51 
Remove options parameter from constructor

SHA: 0f1b519
Reason: push, by @fivedots

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@fivedots fivedots mentioned this pull request Apr 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-sully a-sully a-sully approved these changes

@tomayac tomayac tomayac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fivedots @tomayac @a-sully