Mark options parameter as required #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the options parameter for createSyncAccessHandle and createAccessHandle required, to make it clear that a default behavior has not been decided yet. Add a note about this on "Exposing AccessHandles on all filesystems", mentioning that the parameter should be made optional eventually.
tomayac
reviewed
Mar 23, 2022
tomayac
approved these changes
Mar 23, 2022
Co-authored-by: Thomas Steiner <[email protected]>
a-sully
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
LGTM. I'll mention whatwg/fs#19 here since this is closely related
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the options parameter for createSyncAccessHandle and createAccessHandle required, to make it clear that a default behavior has not been decided yet.
Add a note about this on "Exposing AccessHandles on all filesystems", mentioning that the parameter should be made optional eventually.