Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccessHandles to spec #344

Closed
wants to merge 19 commits into from
Closed

Add AccessHandles to spec #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bab25df
Add SyncAccessHandle to spec, with TODOs
fivedots Oct 19, 2021
8c77176
Add non-normative description to create method
fivedots Nov 2, 2021
dff9235
Add locks
fivedots Nov 3, 2021
8da0508
Make create options mandatory
fivedots Nov 3, 2021
a1a1337
Fix |handle|/|fileHandle| confusion on close()
fivedots Nov 3, 2021
e97fba4
Typo
fivedots Nov 3, 2021
ad31fa9
Update index.bs
fivedots Nov 22, 2021
4309d6c
Update index.bs
fivedots Nov 22, 2021
d2491bc
Update index.bs
fivedots Nov 22, 2021
ddbf192
Remove Naming question, update TOC
fivedots Feb 2, 2022
1adb259
Fix TOC
fivedots Feb 2, 2022
f48edf2
Fix drag and drop example (#357)
tomayac Feb 11, 2022
3c94fea
Rename my library in README (#346)
tomayac Feb 11, 2022
91fbb6d
Fill in read, write, close
fivedots Feb 28, 2022
008de22
Add SyncAccessHandle truncate/getSize
fivedots Mar 17, 2022
0cf3fcf
Remove options parameter
fivedots Apr 5, 2022
e2cf15a
Reply to Domenic's feedback pt.1
fivedots Apr 7, 2022
23751ca
Reply to Domenic's feedback pt.2
fivedots Apr 7, 2022
99725c0
Domenic's feedback pt.3
fivedots Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions AccessHandle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
- [New data access surface](#new-data-access-surface)
- [Locking semantics](#locking-semantics)
- [Open Questions](#open-questions)
- [Naming](#naming)
- [Exposing AccessHandles on all filesystems](#exposing-accesshandles-on-all-filesystems)
- [Assurances on non-awaited consistency](#assurances-on-non-awaited-consistency)
- [Appendix](#appendix)
- [AccessHandle IDL](#accesshandle-idl)
Expand Down Expand Up @@ -184,12 +184,6 @@ observe changes done through the new API, even if a lock is still being held.

## Open Questions

### Naming

The exact name of the new methods hasn’t been defined. The current placeholder
for data access is *createAccessHandle()* and *createSyncAccessHandle()*.
*createUnflushedStreams()* and *createDuplexStream()* have been suggested.

### Exposing AccessHandles on all filesystems

This proposal only currently considers additions to OPFS, but it would probably
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Today, if a web site wants to create experiences involving local files (document
- Clean up if necessary (`URL.revokeObjectURL(a.href)`)

This is also the approach taken in the
[browser-nativefs](https://github.com/GoogleChromeLabs/browser-nativefs)
[browser-fs-access](https://github.com/GoogleChromeLabs/browser-fs-access)
support library.
- Setting `window.location` to `'data:application/octet-stream' + data_stream`.
- Hidden Flash controls to display a “save as” dialog.
Expand Down
Loading