Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in example in specification #356

Closed
tmcw opened this issue Jan 21, 2022 · 0 comments · Fixed by #357
Closed

Bug in example in specification #356

tmcw opened this issue Jan 21, 2022 · 0 comments · Fixed by #357

Comments

@tmcw
Copy link

tmcw commented Jan 21, 2022

https://wicg.github.io/file-system-access/#drag-and-drop

CleanShot 2022-01-21 at 15 35 56@2x

As I mentioned about a web.dev example - https://twitter.com/tmcw/status/1481649674708676608 - this example includes a bug. If there are multiple files, the await in this loop will cause the next iteration of the loop to start on the next tick, and by then the dataTransfer will be disconnected. Working around this requires copying the dataTransfer.items array or saving the resolution of those Promise values to a Promise.all.

tomayac added a commit to tomayac/native-file-system that referenced this issue Jan 24, 2022
mkruisselbrink pushed a commit that referenced this issue Feb 11, 2022
* Fix drag and drop example

Fixes #356

* Update index.bs
github-actions bot added a commit that referenced this issue Feb 11, 2022
* Fix drag and drop example

Fixes #356

* Update index.bs

SHA: 2ccefeb
Reason: push, by @mkruisselbrink

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
fivedots pushed a commit that referenced this issue Feb 28, 2022
* Fix drag and drop example

Fixes #356

* Update index.bs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant