Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automatic beacons to require opt-in before sending #129

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Update automatic beacons to require opt-in before sending #129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2058d39
update to include latest changes
blu25 Oct 13, 2023
2e2da70
Merge branch 'master' into liam-automatic-beacon-opt-in
blu25 Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions spec.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1688,8 +1688,7 @@ successful [=navigate|navigation=] to a [=top-level traversable=].
1. Let |beacon data| be |config|'s [=fenced frame config instance/fenced frame reporter=]'s
[=fenced frame reporter/automatic beacon data=].

1. Let |event data| be |beacon data|'s [=automatic beacon data/eventData=] if |beacon data| is not
null, the empty string otherwise.
1. If |beacon data| is null, abort these steps.

1. If |sourceOrigin| is not [=same origin=] with |config|'s [=fenced frame config instance/mapped
url=]'s [=url/origin=], abort these steps.
Expand All @@ -1698,11 +1697,6 @@ successful [=navigate|navigation=] to a [=top-level traversable=].
reporter=]'s [=fenced frame reporter/fenced frame reporting metadata reference=]'s
[=fencedframetype/fenced frame reporting map=]'s [=map/keys=]:

1. Let |eventData| be an empty [=string=].

1. If |beacon data|'s [=automatic beacon data/destinations=] [=list/contains=] |destination|,
set |eventData| to |event data|.

1. Run [=report an event=] using |config|'s [=fenced frame config instance/fenced frame
reporter=] with |destination| and a [=fencedframetype/destination enum event=] with the
following [=struct/items=]:
Expand All @@ -1711,7 +1705,8 @@ successful [=navigate|navigation=] to a [=top-level traversable=].
:: |eventType|

: [=destination enum event/data=]
:: |eventData|
:: |beacon data|'s [=automatic beacon data/eventData=] if |beacon data|'s [=automatic beacon
data/destinations=] [=list/contains=] |destination|, the empty string otherwise.

: [=destination enum event/attributionReportingEnabled=]
:: |sourceSnapshotParams|'s [=source snapshot params/attribution reporting enabled=]
Expand All @@ -1729,6 +1724,7 @@ successful [=navigate|navigation=] to a [=top-level traversable=].
/fenced-frame/automatic-beacon-two-events-persist.https.html
/fenced-frame/automatic-beacon-unfenced-top.https.html
/fenced-frame/automatic-beacon-no-destination.https.html
/fenced-frame/automatic-beacon-no-opt-in.https.html
</wpt>
</div>

Expand Down