Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec draft #40

Merged
merged 9 commits into from
Feb 25, 2022
Merged

Add spec draft #40

merged 9 commits into from
Feb 25, 2022

Conversation

phoglenix
Copy link
Collaborator

@phoglenix phoglenix commented Dec 23, 2021

@phoglenix phoglenix requested a review from rsolomakhin January 5, 2022 02:14
Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good % a couple of small corrections.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phoglenix phoglenix requested a review from pwnall January 24, 2022 01:22
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 31, 2022
Spec is in draft format now:
WICG/digital-goods#40

Change-Id: I37943fbd6956cb6b3b23491ede0bcaeee82a9990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3361870
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Glen Robertson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#965041}
phoglenix added a commit that referenced this pull request Feb 1, 2022
Version from #40
This might be immediately overwritten by automated compilation.
@phoglenix
Copy link
Collaborator Author

No outstanding review comments, so going ahead with merge. Feel free to raise more issues on the repo if changes are needed.

@phoglenix phoglenix merged commit 54379aa into WICG:main Feb 25, 2022
@phoglenix phoglenix deleted the add-spec-draft branch February 25, 2022 02:34
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
Spec is in draft format now:
WICG/digital-goods#40

Change-Id: I37943fbd6956cb6b3b23491ede0bcaeee82a9990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3361870
Reviewed-by: Rouslan Solomakhin <[email protected]>
Commit-Queue: Glen Robertson <[email protected]>
Cr-Commit-Position: refs/heads/main@{#965041}
NOKEYCHECK=True
GitOrigin-RevId: 2604abc5b5575497c7e0aa6c0096850d5ae24cc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants