Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] DigitalCredentialRequestOptions and DigitalCredential objects must be JSON serializable #125

Open
timcappalli opened this issue Jun 12, 2024 · 2 comments · May be fixed by #179
Open
Assignees
Labels
cgr1-blocker Community Group Report 1 Blocker spec

Comments

@timcappalli
Copy link
Member

In WebAuthn L3, we introduced new methods (toJSON, parseCreationOptionsFromJSON, and parseRequestOptionsFromJSON) for serializing responses and for deserializing requests.

This both improves the developer experience and also allows us to reference these methods directly in the CTAP specification for hybrid transports, instead of defining the encoding and structure there.

@timcappalli
Copy link
Member Author

TPAC discussion: nice to have, but don't block for CGR-1

@leecam
Copy link
Collaborator

leecam commented Oct 3, 2024

Yeah to follow up from TPAC. I think we agreed that if we update the spec to say that the DigitalCredentialRequestOptions and DigitalCredential objects must be JSON serializable (else its an error), then i think we can close this without defining explicit methods.

And to provide a bit of context on the conversion. webauthn's PublicKeyCredentialRequestOptions needs this method because it is specified in a way which isn't naturally JSON serializable, so it needs explicit methods to define how to make the conversions. We can avoid that if we just specify our objects are JSON serializable from the start

@timcappalli timcappalli changed the title [spec] Add JSON (de)serialization methods [spec] DigitalCredentialRequestOptions and DigitalCredential objects must be JSON serializable Oct 7, 2024
timcappalli added a commit that referenced this issue Oct 8, 2024
@timcappalli timcappalli linked a pull request Oct 8, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cgr1-blocker Community Group Report 1 Blocker spec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants