Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing onLine definition #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jakearchibald
Copy link
Collaborator

Does it make sense to reference navigator.onLine here as a minimum viable definition?

Also, I adjusted the wording to suggest the UA may use connectivity to the target origin as a signal. Does this fit with the intention of this definition?

Does it make sense to reference `navigator.onLine` here as a minimum viable definition?

Also, I adjusted the wording to suggest the UA may use *connectivity* to the target origin as a signal. Does this fit with the intention of this definition?
@annevk
Copy link
Contributor

annevk commented Oct 12, 2015

This does not make much sense as an implementation requirement since navigator.onLine can be overwritten. You need to use some kind of underlying concept.

@jakearchibald
Copy link
Collaborator Author

@annevk to clarify, this would mean creating a concept that https://html.spec.whatwg.org/multipage/browsers.html#dom-navigator-online would use for .onLine, then background sync could reference it too?

@annevk
Copy link
Contributor

annevk commented Oct 12, 2015

Yeah, thought we already had such a thing but I guess we don't.

@mkruisselbrink
Copy link
Collaborator

I thought about somehow trying to reference navigator.onLine here, but ended up not doing so since its definition is inside section 7.7, which has the scary "This feature is in the process of being removed from the Web platform." warning. But maybe that warning doesn't apply to all parts of that section?

I also considered that it might make sense to somehow link this to some definition in the netinfo spec, but that didn't seem to have anything obvious to reuse either.

@annevk
Copy link
Contributor

annevk commented Oct 13, 2015

That warning only applies to AppCache.

@yoavweiss yoavweiss changed the base branch from master to main March 5, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants