refactor: move sorting variables to enum

WFZ1 · Aug 12, 2024 · e15465a · e15465a
1 parent 85373e9
commit e15465a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/components/ui/data-table/data-table-column-with-sorting.tsx b/src/components/ui/data-table/data-table-column-with-sorting.tsx
@@ -1,4 +1,5 @@
 import { Button } from '@/components/ui/button';
+import { SORTING_TYPE } from '@/constants';
 import { Column } from '@tanstack/react-table';
 import { ArrowUpDown } from 'lucide-react';
 
@@ -12,7 +13,7 @@ export const DataTableColumnWithSorting = <TData, TValue>({
     title,
 }: DataTableColumnWithSortingProps<TData, TValue>) => {
     return (
-        <Button variant="ghost" onClick={() => column.toggleSorting(column.getIsSorted() === 'asc')}>
+        <Button variant="ghost" onClick={() => column.toggleSorting(column.getIsSorted() === SORTING_TYPE.ASC)}>
             {title}
             <ArrowUpDown className="ml-2 h-4 w-4" />
         </Button>

diff --git a/src/constants.tsx b/src/constants.tsx
@@ -30,3 +30,8 @@ export const COMPLETED = [
 ];
 
 export const DATE_FORMAT = 'MMM dd, yyyy';
+
+export const SORTING_TYPE = {
+    ASC: 'asc',
+    DESC: 'desc'
+};