Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for Sentient Anomalies #431

Merged
merged 3 commits into from
May 6, 2020
Merged

Temporary fix for Sentient Anomalies #431

merged 3 commits into from
May 6, 2020

Conversation

EricSihaoLin
Copy link
Member

Summary:

Stop-gap fix for Sentient Anomalies changes recently until a more permanent solution is found.


Fixes issue (include link):


Mockups, screenshots, evidence:

image

@EricSihaoLin EricSihaoLin requested a review from a team as a code owner May 6, 2020 14:56
@vercel
Copy link

vercel bot commented May 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/wfcd/warframe-hub/l6e4qo7qj
✅ Preview: https://warframe-hub-git-anomaly-tempfix.wfcd.now.sh

@TobiTenno TobiTenno temporarily deployed to warframe-hub-anomaly-te-0dzdbw May 6, 2020 14:57 Inactive
@EricSihaoLin EricSihaoLin requested a review from TobiTenno May 6, 2020 14:57
@TobiTenno TobiTenno temporarily deployed to warframe-hub-anomaly-te-0dzdbw May 6, 2020 15:13 Inactive

import sentient from '@/assets/img/factions/sentient.svg';

export default {
name: 'SentientOutpostsPanel',
props: ['sentientOutposts'],
watch: {
mission: function () {
this.active = new Date().getTime();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhh, let's just use outpost.activation? i can go fix it on the api, this is just kinda jank 🤔

@WFCD WFCD deleted a comment from TobiTenno May 6, 2020
replace by using "activation" and "expiry" which will always be present
@TobiTenno TobiTenno temporarily deployed to warframe-hub-anomaly-te-0dzdbw May 6, 2020 15:18 Inactive
@EricSihaoLin
Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

See the complete overview on Codacy

@TobiTenno TobiTenno merged commit b5d51f4 into dev May 6, 2020
@TobiTenno TobiTenno deleted the anomaly-tempfix branch May 6, 2020 15:31
@wfcd-bot-boi
Copy link
Collaborator

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants