Fomorian/Razorback construction and Events #125

TobiTenno · 2017-09-19T19:59:43Z

No description provided.

stickler-ci · 2017-09-19T20:00:53Z

src/embeds/ConstructionEmbed.js

+
+    this.color = 0xff6961;
+    this.fields = [{
+        name: `[${platform}] Construction Status:`,


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:00:53Z

src/embeds/ConstructionEmbed.js

+    this.color = 0xff6961;
+    this.fields = [{
+        name: `[${platform}] Construction Status:`,
+        value: '```' +


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:00:53Z

src/embeds/ConstructionEmbed.js

+    this.fields = [{
+        name: `[${platform}] Construction Status:`,
+        value: '```' +
+        `Razorback: ${construction.razorbackProgress}` +


'construction' is not defined. (no-undef)

stickler-ci · 2017-09-19T20:00:54Z

src/embeds/ConstructionEmbed.js

+        name: `[${platform}] Construction Status:`,
+        value: '```' +
+        `Razorback: ${construction.razorbackProgress}` +
+        `Fomorian:  ${construction.fomorianProgress}` +


'construction' is not defined. (no-undef)

stickler-ci · 2017-09-19T20:00:55Z

src/embeds/ConstructionEmbed.js

+        value: '```' +
+        `Razorback: ${construction.razorbackProgress}` +
+        `Fomorian:  ${construction.fomorianProgress}` +
+        `Unknown:   ${construction.unknwonProgress}` +


'construction' is not defined. (no-undef)

stickler-ci · 2017-09-19T20:00:58Z

src/embeds/ConstructionEmbed.js

+        `Razorback: ${construction.razorbackProgress}` +
+        `Fomorian:  ${construction.fomorianProgress}` +
+        `Unknown:   ${construction.unknwonProgress}` +
+        '```'


Missing trailing comma. (comma-dangle)

stickler-ci · 2017-09-19T20:00:59Z

src/embeds/EventEmbed.js

+    this.color = 0xfdec96;
+
+    if (event) {
+        this.title = `[${platform}] ${event.description}`;


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:00:59Z

src/embeds/EventEmbed.js

+
+    if (event) {
+        this.title = `[${platform}] ${event.description}`;
+        this.fields = [];


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:01:00Z

src/embeds/EventEmbed.js

+        this.title = `[${platform}] ${event.description}`;
+        this.fields = [];
+
+        if (event.victimNode) {


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:01:00Z

src/embeds/EventEmbed.js

+        this.fields = [];
+
+        if (event.victimNode) {
+            this.fields.push({name: '_ _', value: `Defend ${event.victimNode} by attacking the ${event.faction} at ${event.node}.` });


Expected indentation of 10 spaces but found 12. (indent)
A space is required after '{'. (object-curly-spacing)

stickler-ci · 2017-09-19T20:01:01Z

src/embeds/EventEmbed.js

+        if (event.victimNode) {
+            this.fields.push({name: '_ _', value: `Defend ${event.victimNode} by attacking the ${event.faction} at ${event.node}.` });
+        }
+        this.fields.push({ name: 'Rewards', value: event.rewards.map(reward => reward.asString).join('; ') });


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:01:02Z

src/embeds/EventEmbed.js

+            this.fields.push({name: '_ _', value: `Defend ${event.victimNode} by attacking the ${event.faction} at ${event.node}.` });
+        }
+        this.fields.push({ name: 'Rewards', value: event.rewards.map(reward => reward.asString).join('; ') });
+        this.fields.push({ name: 'Completion Score', value: String(event.maximumScore) });


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:01:03Z

src/embeds/EventEmbed.js

+        this.fields.push({ name: 'Rewards', value: event.rewards.map(reward => reward.asString).join('; ') });
+        this.fields.push({ name: 'Completion Score', value: String(event.maximumScore) });
+    } else {
+        this.title = 'No Current Events';


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:01:38Z

src/commands/Worldstate/Construction.js

+    const platformParam = message.strippedContent.match(this.regex)[1];
+    const platform = platformParam || await this.bot.settings.getChannelSetting(message.channel, 'platform');
+    const ws = await this.bot.caches[platform].getDataJson();
+    await this.messageManager.embed(message, new EventEmbed(this.bot, ws.constructionProgress, platform.toUpperCase()), true, true));


Parsing error: Unexpected token )

stickler-ci · 2017-09-19T20:01:40Z

src/commands/Worldstate/Event.js

+        await Promise.all(results);
+        return this.messageManager.statuses.SUCCESS;
+    }
+    await this.messageManager.embed(message, new EventEmbed(this.bot, undefined, platform.toUpperCase()), true, true));


Parsing error: Unexpected token )

stickler-ci · 2017-09-19T20:04:20Z

src/commands/Worldstate/Construction.js

+    const platformParam = message.strippedContent.match(this.regex)[1];
+    const platform = platformParam || await this.bot.settings.getChannelSetting(message.channel, 'platform');
+    const ws = await this.bot.caches[platform].getDataJson();
+    await this.messageManager.embed(message, new EventEmbed(this.bot, ws.constructionProgress, platform.toUpperCase()), true, true);


Line 23 exceeds the maximum line length of 100. (max-len)

stickler-ci · 2017-09-19T20:04:21Z

src/commands/Worldstate/Event.js

+        await Promise.all(results);
+        return this.messageManager.statuses.SUCCESS;
+    }
+    await this.messageManager.embed(message, new EventEmbed(this.bot, undefined, platform.toUpperCase()), true, true));


Parsing error: Unexpected token )

stickler-ci · 2017-09-19T20:04:54Z

src/commands/Worldstate/Event.js

+    const platform = platformParam || await this.bot.settings.getChannelSetting(message.channel, 'platform');
+    const ws = await this.bot.caches[platform].getDataJson();
+    if (ws.events.length > 0) {
+        const results = [];


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:04:54Z

src/commands/Worldstate/Event.js

+    const ws = await this.bot.caches[platform].getDataJson();
+    if (ws.events.length > 0) {
+        const results = [];
+        ws.events.forEach(event => {


Expected indentation of 6 spaces but found 8. (indent)
Expected parentheses around arrow function argument having a body with curly braces. (arrow-parens)

stickler-ci · 2017-09-19T20:04:54Z

src/commands/Worldstate/Event.js

+    if (ws.events.length > 0) {
+        const results = [];
+        ws.events.forEach(event => {
+            results.push(this.messageManager.embed(message, new EventEmbed(this.bot, event, platform.toUpperCase()), true, true));


Line 26 exceeds the maximum line length of 100. (max-len)
Expected indentation of 10 spaces but found 12. (indent)

stickler-ci · 2017-09-19T20:04:55Z

src/commands/Worldstate/Event.js

+        ws.events.forEach(event => {
+            results.push(this.messageManager.embed(message, new EventEmbed(this.bot, event, platform.toUpperCase()), true, true));
+        });
+        await Promise.all(results);


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:04:55Z

src/commands/Worldstate/Event.js

+            results.push(this.messageManager.embed(message, new EventEmbed(this.bot, event, platform.toUpperCase()), true, true));
+        });
+        await Promise.all(results);
+        return this.messageManager.statuses.SUCCESS;


Expected indentation of 6 spaces but found 8. (indent)

stickler-ci · 2017-09-19T20:04:56Z

src/commands/Worldstate/Event.js

+        await Promise.all(results);
+        return this.messageManager.statuses.SUCCESS;
+    }
+    await this.messageManager.embed(message, new EventEmbed(this.bot, undefined, platform.toUpperCase()), true, true);


Line 31 exceeds the maximum line length of 100. (max-len)

stickler-ci · 2017-09-19T20:04:56Z

src/embeds/ConstructionEmbed.js

+    this.fields = [{
+      name: `[${platform}] Construction Status:`,
+      value: '```' +
+      `Razorback: ${construction.razorbackProgress}` +


'construction' is not defined. (no-undef)

stickler-ci · 2017-09-19T20:04:57Z

src/embeds/ConstructionEmbed.js

+      name: `[${platform}] Construction Status:`,
+      value: '```' +
+      `Razorback: ${construction.razorbackProgress}` +
+      `Fomorian:  ${construction.fomorianProgress}` +


'construction' is not defined. (no-undef)

stickler-ci · 2017-09-19T20:04:57Z

src/embeds/ConstructionEmbed.js

+      value: '```' +
+      `Razorback: ${construction.razorbackProgress}` +
+      `Fomorian:  ${construction.fomorianProgress}` +
+      `Unknown:   ${construction.unknwonProgress}` +


'construction' is not defined. (no-undef)

stickler-ci · 2017-09-19T20:04:58Z

src/embeds/ConstructionEmbed.js

+      `Razorback: ${construction.razorbackProgress}` +
+      `Fomorian:  ${construction.fomorianProgress}` +
+      `Unknown:   ${construction.unknwonProgress}` +
+      '```'


Missing trailing comma. (comma-dangle)

stickler-ci · 2017-09-19T20:05:31Z

src/embeds/EventEmbed.js

+      this.fields = [];
+
+      if (event.victimNode) {
+          this.fields.push({name: '_ _', value: `Defend ${event.victimNode} by attacking the ${event.faction} at ${event.node}.` });


Expected indentation of 8 spaces but found 10. (indent)
A space is required after '{'. (object-curly-spacing)

stickler-ci · 2017-09-19T20:08:50Z

src/commands/Worldstate/Event.js

+    const ws = await this.bot.caches[platform].getDataJson();
+    if (ws.events.length > 0) {
+      const results = [];
+      ws.events.forEach(event => {


Expected parentheses around arrow function argument having a body with curly braces. (arrow-parens)

stickler-ci · 2017-09-19T20:08:50Z

src/commands/Worldstate/Event.js

+    if (ws.events.length > 0) {
+      const results = [];
+      ws.events.forEach(event => {
+          results.push(this.messageManager.embed(message, 


Expected indentation of 8 spaces but found 10. (indent)
Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2017-09-19T20:08:51Z

src/commands/Worldstate/Event.js

+      await Promise.all(results);
+      return this.messageManager.statuses.SUCCESS;
+    }
+    await this.messageManager.embed(message, new EventEmbed(this.bot, 


Trailing spaces not allowed. (no-trailing-spaces)

stickler-ci · 2017-09-19T20:10:41Z

src/commands/Worldstate/Event.js

+    if (ws.events.length > 0) {
+      const results = [];
+      ws.events.forEach((event) => {
+          results.push(this.messageManager.embed(message,


Expected indentation of 8 spaces but found 10. (indent)

stickler-ci · 2017-09-19T20:10:41Z

src/embeds/EventEmbed.js

+      this.fields = [];
+
+      if (event.victimNode) {
+        this.fields.push({ name: '_ _', value: `Defend ${event.victimNode}` +


Object properties must go on a new line if they aren't all on the same line. (object-property-newline)

TobiTenno · 2017-09-19T20:22:34Z

gonna test these when i'm home before i give it the ol +1

* adding embeds * Add commands for previously added embeds * fix bad parentheses * fix parens * fix indents * fix indents * fix comma and syntax (construction didn't exist) * fix some indents and line length * fix line length * fix line length * stickler fixes * fix indentation * fix indents * Update EventEmbed.js * add health to event * add platform to notifications and commands default trials to auto-delete update raven change some logic for pricecheck embeds fix for event embed messup fix reward map issue fix bad news embed call add type for prime access notifications another of above for updates test fix for set ping Async fixes (#126) * make fatals and errors not log twice, cleanup logger typedef * add logging for notifier * fix some missing awaits. * cleanup some debugs * slim down debug * more debugs * more * hopeful fix, awaiting callback function * better formatting, abstract out wiki search for image * fix construction progress * more formatting for construction embed

* adding embeds * Add commands for previously added embeds * fix bad parentheses * fix parens * fix indents * fix indents * fix comma and syntax (construction didn't exist) * fix some indents and line length * fix line length * fix line length * stickler fixes * fix indentation * fix indents * Update EventEmbed.js * add health to event * add platform to notifications and commands default trials to auto-delete update raven change some logic for pricecheck embeds fix for event embed messup fix reward map issue fix bad news embed call add type for prime access notifications another of above for updates test fix for set ping Async fixes (#126) * make fatals and errors not log twice, cleanup logger typedef * add logging for notifier * fix some missing awaits. * cleanup some debugs * slim down debug * more debugs * more * hopeful fix, awaiting callback function * better formatting, abstract out wiki search for image * fix construction progress * more formatting for construction embed Fomorian/Razorback construction and Events (#125) * adding embeds * Add commands for previously added embeds * fix bad parentheses * fix parens * fix indents * fix indents * fix comma and syntax (construction didn't exist) * fix some indents and line length * fix line length * fix line length * stickler fixes * fix indentation * fix indents * Update EventEmbed.js * add health to event * add platform to notifications and commands default trials to auto-delete update raven change some logic for pricecheck embeds fix for event embed messup fix reward map issue fix bad news embed call add type for prime access notifications another of above for updates test fix for set ping Async fixes (#126) * make fatals and errors not log twice, cleanup logger typedef * add logging for notifier * fix some missing awaits. * cleanup some debugs * slim down debug * more debugs * more * hopeful fix, awaiting callback function * better formatting, abstract out wiki search for image * fix construction progress * more formatting for construction embed fix an await in a loop Merge branch 'morefixes'

adding embeds

3d78ff7

TobiTenno added the Status: In Progress Work has Begun label Sep 19, 2017

TobiTenno changed the title ~~adding embeds~~ Fomorian/Razorback construction and Events Sep 19, 2017

stickler-ci reviewed Sep 19, 2017

View reviewed changes

Add commands for previously added embeds

d5499f2

stickler-ci reviewed Sep 19, 2017

View reviewed changes

TobiTenno added 2 commits September 19, 2017 15:03

fix bad parentheses

b61d0cd

fix parens

7b7cda0

stickler-ci reviewed Sep 19, 2017

View reviewed changes

fix indents

dd10bd2

stickler-ci reviewed Sep 19, 2017

View reviewed changes

fix indents

cb6b80c

stickler-ci reviewed Sep 19, 2017

View reviewed changes

TobiTenno added 4 commits September 19, 2017 15:05

fix comma and syntax (construction didn't exist)

658e157

fix some indents and line length

fde711a

fix line length

d8e0f4b

fix line length

bb1b8d1

stickler-ci reviewed Sep 19, 2017

View reviewed changes

stickler fixes

bc88b3d

stickler-ci reviewed Sep 19, 2017

View reviewed changes

TobiTenno added 3 commits September 19, 2017 15:11

fix indentation

9b7653e

fix indents

a47c012

Update EventEmbed.js

6a86c7c

TobiTenno added 2 commits September 19, 2017 21:12

add health to event

9e34fbe

add platform to notifications and commands

55ac182

TobiTenno merged commit 04165a6 into master Sep 20, 2017

TobiTenno removed the Status: In Progress Work has Begun label Sep 20, 2017

TobiTenno deleted the aliasfalse/construction-and-events branch September 21, 2017 01:56

snyk-bot mentioned this pull request Nov 2, 2020

[Snyk] Upgrade bufferutil from 4.0.1 to 4.0.2 #408

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fomorian/Razorback construction and Events #125

Fomorian/Razorback construction and Events #125

TobiTenno commented Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

stickler-ci Sep 19, 2017

TobiTenno commented Sep 19, 2017

Fomorian/Razorback construction and Events #125

Fomorian/Razorback construction and Events #125

Conversation

TobiTenno commented Sep 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TobiTenno commented Sep 19, 2017