Floating OWC example using the two rigid body approach v2

[MShabara]

Adds Floating OWC example, the model includes the following:

Air Chamber Dynamics.
Generator Performance Curves.
Wells Turbine Dynamics and Performance Curves.
optimal control that maximizes the turbine's efficiency (TEM)

[MShabara]

Hi @jleonqu

The test is failing because the the .gitignore rules preventing me from committing the .h5 file for test17a. I am unable to generate the necessary WAMIT output file due to a license issue at NREL.

Could you kindly assist by running the WAMIT simulation for test17a and providing the output file? Once generated, could you also add the file to the OWC old example in the repository?

[jleonqu]

Hi @MShabara

The PR is passing the tests locally in my laptop, but for some reason it's not passing the tests here. I tried many different things to to fix this issue, but it persists. I edited the .gitignore file to upload the test17a.h5 file, and I also tried to use the original files from dev for the orificeModel example. Can you take a look to this problem? I run the tests locally in Matlab R2022b and Matlab 2023b with no issues.

[jtgrasb]

@jleonqu It looks like its more of a GitHub Issue, and both the dev and main branch are failing the most recent checks too.

@H0R5E do you have any ideas why these are failing again? Perhaps related to PR #75?

[H0R5E]

@H0R5E do you have any ideas why these are failing again? Perhaps related to PR #75?

Hi @jtgrasb, it looks like the products.txt file has been moved to the wrong location. This is required for selecting the toolboxes to be installed, and it should be at the top level of the test directory, i.e. OWC/products.txt.

If you move this up a level, it should start working, unless additional toolboxes are needed.

FYI, I'm not maintaining this repo at the moment, so you should probably ping @akeeste or @kmruehl next time.

Hope that helps,

Mat

[H0R5E]

@jtgrasb, you're also right that these tests are timing out on the dev branch. You might consider making a change to the workflows like this or just removing the timeout, entirely.

It was put there to avoid hung tests waiting for the default 6 hours to be cancelled, but I'm not sure if it's an issue any more.

[jtgrasb]

@H0R5E Didn't realize you weren't still part of the maintainers. Thank you anyway for taking a look!

[jtgrasb]

I removed the case which tests the mcr for the orifice because the tests were timing out here. @dforbush2 Is there a good reason to test your orifice model OWC case with MCR? It seems like it is superfluous since we already test the OWC and the MCR on their own.

@MShabara Can you move the testOWC.m script to the main OWC folder and test both the orifice model and the floating OWC?

[dforbush2]

No need to test the OWC with MCR in the tests…the OWC application does utilize MCR to build a surface plot but doesn’t need to be tested as such. But please do make sure the OWC runs just with a WECSim call (I.e, it doesn’t depend on WEC-SimMCR to define working variables)

…

________________________________ From: jtgrasb ***@***.***> Sent: Monday, December 16, 2024 7:46:27 AM To: WEC-Sim/WEC-Sim_Applications ***@***.***> Cc: Forbush, Dominic Dean ***@***.***>; Mention ***@***.***> Subject: [EXTERNAL] Re: [WEC-Sim/WEC-Sim_Applications] Floating OWC example using the two rigid body approach v2 (PR #77) I removed the case which tests the mcr for the orifice because the tests were timing out here. @dforbush2<https://github.com/dforbush2> Is there a good reason to test your orifice model OWC case with MCR? It seems like it is superfluous since we already test the OWC and the MCR on their own. @MShabara<https://github.com/MShabara> Can you move the testOWC.m script to the main OWC folder and test both the orifice model and the floating OWC? — Reply to this email directly, view it on GitHub<#77 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHF2G7HXKAXAABG5WR2S3ZT2F3YVHAVCNFSM6AAAAABSXOVEBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBVHE3TQMZTHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>