Resolve bugs

[akeeste]

This PR complements WEC-Sim/WEC-Sim#1317

[akeeste]

Applications to fix:

• Controls - fixed here. Fixed references to h5File which is now a cell array of strings
• GBM - fixed in Resolve conflicts between variable hydro and GBM WEC-Sim#1317 commits
• MOST --> this one does not have runtime errors, but a large difference from the previous result. i don't yet know what's causing that difference. As @jtgrasb mentioned, perhaps related to the convergence of the mostIO pre-processing step.
• Mean Drift - fixed here. Fixed references to h5File which is now a cell array of strings
• Mooring (User defined Fex) - fixed in Resolve conflicts between variable hydro and GBM WEC-Sim#1317 commits
• OWC - fixed in Resolve conflicts between variable hydro and GBM WEC-Sim#1317 commits
• WECCCOMP MPC --> fixed here. This case failed because the wecSimInputFile.m in that case intentionally defined a simu.cicEndTime = [] which then prevent the IRF from being calculated correctly. I replaced this empty definition with that of the other WECCCOMP cases. Perhaps a change in the initialization on dev resulted in this input file definition causing an error--as it should have.

[akeeste]

I reran the tests (R2023b) using identical input files from mostIO, but the results still differ from previous output. Summarizing failed tests here for discussion:

• Error in turbulent body pitch position is greater than the tolerance (0.01%) at 30 time steps with an error ~.0101%
• Error in turbulent blade pitch position is greater than the tolerance (0.01%) at 1 time step with an error ~.01005%
• Error in turbulent tower base load is greater than the tolerance (3%) at 2 time steps with an error of 4% and 16%
• Error in turbulent tower top load is greater than the tolerance (3%) at 6 time steps with an error of 5-15%

Given that the tolerance is arbitrarily set, I'm not concerned about tests 1 and 2 above. Tests 3 and 4 have a large and significant error but only at a very small number of time steps. It surprises me that a single time step could have an error of 16% when those around it have a small error under the tolerance.

We currently don't have a turbSim file committed for consistent regression testing because it is very large. Only turbulent tests are failing so I'm guessing that there's a stochastic process in the turbulent wind field prediction that is creating these relatively large errors at certain wind speeds. I will test this by running a case on WEC-Sim main, saving all input files including WIND_11mps.mat and see if these regression tests pass then on dev.

[akeeste]

Part of my above comment is incorrect--I forgot that run_turbsim() does not actually recreate the wind field, only parses the TurbSim output data into a specific format for MOST. So, there is still strange behavior going on and it's not related to varying TurbSim output.

An identical MOST application passes using WEC-Sim main but not on dev. Still something to figure out...